readme update suggestions #1

Closed
opened 2023-02-21 08:49:31 +00:00 by AbsolutelyFree · 2 comments

Hello Oscar,

First I just wanted to say thank you for this wonderful piece of software. I had to wrestle with it a bit to get it to work, but it is finally functioning properly. You did truly excellent work in creating this.

I want to mention three small issues that I had so that they can maybe be mentioned in the readme to help others. I setup the dls service inside of a Debian 11 proxmox lxc container and followed the directions titled "Debian/Ubuntu (manual method using git clone and python virtual environment)".

  1. The command that I needed to run to test the service was sudo -u www-data /opt/fastapi-dls/venv/bin/uvicorn main:app --app-dir=/opt/fastapi-dls/app, and this was after I had installed sudo with apt install sudo. The su version of the command requires the www-data user to have a login shell, which is not ideal for security. The -c argument for sudo is not valid with the version of sudo on Debian 11.

  2. I didn't realize that I needed to change the DLS_URL variable in the config file until after I checked the logs on my Windows 10 client and saw that it was trying to authenticate at localhost. I also noticed that in the OpenSUSE Leap directions you had a comment in the config file: # Adjust DSL_URL as needed (accessing from LAN won't work with 127.0.0.1) These were the clues I needed to get things working. Could this comment also be added to the config file section of the Debian/Ubuntu manual directions?

  3. When I initially ran the chown command as part of the "Install FastAPI-DLS" section of the directions, this did not set the permissions on the db.sqlite file. I believe that this database file wasn't created yet at the time that I ran the chown command while following the directions. When I was trying to authenticate my Windows 10 client, they kept failing. I didn't realize why this was happening until I checked systemctl status fastapi-dls.service and saw errors saying sqlite3.OperationalError: attempt to write a readonly database. I reran the chown command mentioned in the "Install FastAPI-DLS" section of the directions, rebooted, downloaded a new client token on my win10 client, restarted the service, and then everything worked perfectly.

Thanks again!

Hello Oscar, First I just wanted to say thank you for this wonderful piece of software. I had to wrestle with it a bit to get it to work, but it is finally functioning properly. You did truly excellent work in creating this. I want to mention three small issues that I had so that they can maybe be mentioned in the readme to help others. I setup the dls service inside of a Debian 11 proxmox lxc container and followed the directions titled "Debian/Ubuntu (manual method using git clone and python virtual environment)". 1. The command that I needed to run to test the service was `sudo -u www-data /opt/fastapi-dls/venv/bin/uvicorn main:app --app-dir=/opt/fastapi-dls/app`, and this was after I had installed sudo with `apt install sudo`. The `su` version of the command requires the www-data user to have a login shell, which is not ideal for security. The -c argument for sudo is not valid with the version of sudo on Debian 11. 2. I didn't realize that I needed to change the DLS_URL variable in the config file until after I checked the logs on my Windows 10 client and saw that it was trying to authenticate at localhost. I also noticed that in the OpenSUSE Leap directions you had a comment in the config file: `# Adjust DSL_URL as needed (accessing from LAN won't work with 127.0.0.1)` These were the clues I needed to get things working. Could this comment also be added to the config file section of the Debian/Ubuntu manual directions? 2. When I initially ran the `chown` command as part of the "Install FastAPI-DLS" section of the directions, this did not set the permissions on the db.sqlite file. I believe that this database file wasn't created yet at the time that I ran the `chown` command while following the directions. When I was trying to authenticate my Windows 10 client, they kept failing. I didn't realize why this was happening until I checked `systemctl status fastapi-dls.service` and saw errors saying `sqlite3.OperationalError: attempt to write a readonly database`. I reran the `chown` command mentioned in the "Install FastAPI-DLS" section of the directions, rebooted, downloaded a new client token on my win10 client, restarted the service, and then everything worked perfectly. Thanks again!
Owner

hi @AbsolutelyFree , sorry for replying so late but somehow I forgot about this Gitea instance 🤦🏻‍♂️

  1. The command th ...

so which command works for you?

  1. I didn't realize that I ...

done, thx!

  1. When I initially ran the ...

I think this maybe comes with your fist issue. Maybe "sudo" dose not work properly and the database was created by root user?

thx for your feedback!

hi @AbsolutelyFree , sorry for replying so late but somehow I forgot about this Gitea instance 🤦🏻‍♂️ > 1. The command th ... so which command works for you? > 2. I didn't realize that I ... done, thx! > 3. When I initially ran the ... I think this maybe comes with your fist issue. Maybe "sudo" dose not work properly and the database was created by root user? thx for your feedback!
oscar.krause referenced this issue from a commit 2023-07-04 10:39:17 +00:00
oscar.krause referenced this issue from a commit 2023-07-04 11:35:06 +00:00
Author

I am also guilty of forgetting about this issue, apparently I didn't setup email notifications so my apologies!

The final command that I had needed to run was sudo -u www-data /opt/fastapi-dls/venv/bin/uvicorn main:app --app-dir=/opt/fastapi-dls/app. I am not sure exactly why I needed a different command than what the readme.md stated, this was a long time ago that I set this up. I see that the readme.md and the program itself have been updated heavily since then, so this issue can be closed. It is likely no longer relevant.

I can report that I have been running the version of the program that I installed 9 months now without a single issue this entire time without a single issue. I will be rebuilding my Proxmox cluster once version 8.1 comes out and will be setting up the latest version then. Thank you for such a valuable and reliable piece of software!

I am also guilty of forgetting about this issue, apparently I didn't setup email notifications so my apologies! The final command that I had needed to run was `sudo -u www-data /opt/fastapi-dls/venv/bin/uvicorn main:app --app-dir=/opt/fastapi-dls/app`. I am not sure exactly why I needed a different command than what the readme.md stated, this was a long time ago that I set this up. I see that the readme.md and the program itself have been updated heavily since then, so this issue can be closed. It is likely no longer relevant. I can report that I have been running the version of the program that I installed 9 months now without a single issue this entire time without a single issue. I will be rebuilding my Proxmox cluster once version 8.1 comes out and will be setting up the latest version then. Thank you for such a valuable and reliable piece of software!
oscar.krause referenced this issue from a commit 2024-03-04 20:21:42 +00:00
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: oscar.krause/fastapi-dls#1
No description provided.